[libvirt] [PATCH] libvirt-domain: Drop virDomainMigrateCheckNotLocal attribute

[Jiri Denemark]

On Mon, Oct 12, 2015 at 16:41:49 +0200, Michal Privoznik wrote:
> Our apibuild.py script does not cope with ATTRIBUTE_NONNULL:
> 
> Parse Error: parsing function type, ')' expected
> Got token  ('name', 'char')
> Last token:  ('name', 'char')
> Token queue:  [('op', '*'), ('name', 'dconnuri'), ('sep', ')')]
> Line 3297 end:
> Makefile:2441: recipe for target '../../docs/apibuild.py.stamp' failed
> 
> Let's drop it. Moreover, up until e17ae3ccc2dbc1400 where it was
> introduced we did not really care about NULL-ity of dconnuri. And
> moreover the ATTRIBUTE_NONNULL merely checks for static calls
> over NULL, it won't catch the dynamic ones, where a NULL is
> passed by a variable at runtime.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/libvirt-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index e6c8604..6e1aacd 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -3293,7 +3293,7 @@ virDomainMigrateVersion3Params(virDomainPtr domain,
>  }
>  
>  
> -static int ATTRIBUTE_NONNULL(1)
> +static int
>  virDomainMigrateCheckNotLocal(const char *dconnuri)
>  {
>      virURIPtr tempuri = NULL;

ACK

Jirka