[libvirt] [PATCH] testscripts: make redirects happen in correct order

Wei Jiangang weijg.fnst at cn.fujitsu.com
Wed Oct 14 10:39:13 UTC 2015


It should redirect stdout to /dev/null firstly,
then redirect stderr to whatever stdout currently points at.

Signed-off-by: Wei Jiangang <weijg.fnst at cn.fujitsu.com>
---
 tests/test-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index e612f8f..d36a901 100644
--- a/tests/test-lib.sh
+++ b/tests/test-lib.sh
@@ -248,9 +248,9 @@ trap '(exit $?); exit $?' 1 2 13 15
 
 cd "$t_" || error_ "failed to cd to $t_"
 
-if ( diff --version < /dev/null 2>&1 | grep GNU ) 2>&1 > /dev/null; then
+if ( diff --version < /dev/null 2>&1 | grep GNU ) >/dev/null 2>&1; then
   compare() { diff -u "$@"; }
-elif ( cmp --version < /dev/null 2>&1 | grep GNU ) 2>&1 > /dev/null; then
+elif ( cmp --version < /dev/null 2>&1 | grep GNU ) >/dev/null 2>&1; then
   compare() { cmp -s "$@"; }
 else
   compare() { cmp "$@"; }
-- 
1.9.3




More information about the libvir-list mailing list