[libvirt] [PATCH v1 08/23] security_dac: Plug in remember/recall APIs

[Peter Krempa]

On Mon, Oct 12, 2015 at 12:25:53 +0200, Michal Privoznik wrote:
> Even though the APIs are not implemented yet, they create a
> skeleton that can be filled in later.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/security/security_dac.c | 38 +++++++++++++++++++++++++++++++++-----
>  1 file changed, 33 insertions(+), 5 deletions(-)
> 
> diff --git a/src/security/security_dac.c b/src/security/security_dac.c
> index a38c46c..6c4e351 100644
> --- a/src/security/security_dac.c
> +++ b/src/security/security_dac.c
> @@ -196,7 +196,6 @@ virSecurityDACGetImageIds(virSecurityLabelDefPtr seclabel,
>   * Returns: 0 on success, -1 on failure
>   */
>  static int
> -ATTRIBUTE_UNUSED
>  virSecurityDACRememberLabel(virSecurityDACDataPtr priv ATTRIBUTE_UNUSED,
>                              const char *path ATTRIBUTE_UNUSED,
>                              uid_t uid ATTRIBUTE_UNUSED,

I'd suggest you fold the addition of the stub into this patch. This
patch either does not do much explaining so the separate commits don't
make sense.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151016/58e63beb/attachment-0001.sig>