[libvirt] [PATCH 0/3] NEWS: Split releases by year

[Martin Kletzander]

On Thu, Oct 15, 2015 at 04:12:07PM +0200, Andrea Bolognani wrote:
>As agreed, I've followed up with the cleanups by splitting
>the huge news.html.in file into separate, smaller files,
>one per year.
>
>Along with the split I've also included a fixed XSLT
>stylesheet so that we can start shipping a meaningful
>NEWS file again.
>
>Cheers.
>

I like it, it looks nice, there are just two issues here:

 1) the NEWS file is not generated if I run 'make all', I don't know
    whether that should or should not happen, so feel free to debate
    me on that one,

 2) syntax-check fails with this series, but that's not because there
    would be anything wrong with the files you've added, it's just an
    exclusion rule missing them.  The following should be either
    squashed in the first patch or added as a separate patch before
    the first one:

diff --git i/cfg.mk w/cfg.mk
index e4364348434e..391f37b4c7c6 100644
--- i/cfg.mk
+++ w/cfg.mk
@@ -90,7 +90,7 @@ endif

 # Files that should never cause syntax check failures.
 VC_LIST_ALWAYS_EXCLUDE_REGEX = \
-  (^(HACKING|docs/(news\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$
+  (^(HACKING|docs/(news(-[0-9]*)?\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$

 # Functions like free() that are no-ops on NULL arguments.
 useless_free_options =				\
--

ACK series with that fixed.

>
>Andrea Bolognani (3):
>  NEWS: Split releases by year (2005-2011)
>  NEWS: Split releases by year (2012-2015)
>  NEWS: Fix XSLT stylesheet
>
> docs/news-2005.html.in |    28 +
> docs/news-2006.html.in |   354 +
> docs/news-2007.html.in |   534 ++
> docs/news-2008.html.in |   580 ++
> docs/news-2009.html.in |  1603 ++++
> docs/news-2010.html.in |  2218 ++++++
> docs/news-2011.html.in |  3314 +++++++++
> docs/news-2012.html.in |  3012 ++++++++
> docs/news-2013.html.in |  3675 ++++++++++
> docs/news-2014.html.in |  3418 +++++++++
> docs/news.html.in      | 18544 +----------------------------------------------
> docs/news.xsl          |    30 +-
> 12 files changed, 18759 insertions(+), 18551 deletions(-)
> create mode 100644 docs/news-2005.html.in
> create mode 100644 docs/news-2006.html.in
> create mode 100644 docs/news-2007.html.in
> create mode 100644 docs/news-2008.html.in
> create mode 100644 docs/news-2009.html.in
> create mode 100644 docs/news-2010.html.in
> create mode 100644 docs/news-2011.html.in
> create mode 100644 docs/news-2012.html.in
> create mode 100644 docs/news-2013.html.in
> create mode 100644 docs/news-2014.html.in
>
>--
>2.4.3
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151016/47a5d97e/attachment-0001.sig>