[libvirt] [PATCH 2/9] virt-admin: Introduce first working skeleton

[Martin Kletzander]

On Wed, Oct 14, 2015 at 01:25:13PM +0200, Michal Privoznik wrote:
>On 13.10.2015 15:38, Erik Skultety wrote:
>> This patch introduces virt-admin client which is based on virsh client,
>> but had to reimplement several methods to meet virt-admin specific needs
>> or remove unnecessary virsh specific logic.
>> ---
>>  .gitignore                      |   1 +
>>  daemon/libvirtd.c               |   3 +-
>>  include/libvirt/libvirt-admin.h |   1 +
>>  po/POTFILES.in                  |   1 +
>>  src/libvirt-admin.c             |  31 +++
>>  src/libvirt_admin_public.syms   |   1 +
>>  tools/Makefile.am               |  28 +-
>>  tools/virt-admin.c              | 604 ++++++++++++++++++++++++++++++++++++++++
>>  tools/virt-admin.h              |  71 +++++
>>  9 files changed, 737 insertions(+), 4 deletions(-)
>>  create mode 100644 tools/virt-admin.c
>>  create mode 100644 tools/virt-admin.h
>>
>> diff --git a/.gitignore b/.gitignore
>> index 2d52a8f..a776947 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -176,6 +176,7 @@
>>  /tools/virt-login-shell
>>  /tools/virsh
>>  /tools/virsh-*-edit.c
>> +/tools/virt-admin
>>  /tools/virt-*-validate
>>  /tools/virt-sanlock-cleanup
>>  /tools/wireshark/src/plugin.c
>> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
>> index 250094b..8734f93 100644
>> --- a/daemon/libvirtd.c
>> +++ b/daemon/libvirtd.c
>> @@ -522,8 +522,7 @@ daemonSetupNetworking(virNetServerPtr srv,
>>          virNetServerAddService(srv, svcRO, NULL) < 0)
>>          goto cleanup;
>>
>> -    /* Temporarily disabled */
>> -    if (sock_path_adm && false) {
>> +    if (sock_path_adm) {

Also (as said already, I'm sure you did this by mistake) this should
go in with version change to 1.3 and no earlier then when we decide we
have first set of APIs.  I know you'r enot going to push this, but I'm
just making sure that someone will not push or ACK it by mistake.
Thanks.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151016/c5f6444b/attachment-0001.sig>