[libvirt] [PATCH 1/2] Prefer STREQ and STRNEQ

Michal Privoznik mprivozn at redhat.com
Tue Oct 20 14:28:03 UTC 2015


On 07.10.2015 19:31, Ishmanpreet Khera wrote:
> use STRNEQ instead of !STREQ to remove inconsistency.
> 
> Signed-off-by: Ishmanpreet Kaur Khera <khera.ishman at gmail.com>
> ---
>  src/bhyve/bhyve_driver.c              |  2 +-
>  src/conf/network_conf.c               |  4 ++--
>  src/conf/nwfilter_conf.c              |  2 +-
>  src/conf/nwfilter_params.c            |  2 +-
>  src/conf/storage_conf.c               |  2 +-
>  src/lxc/lxc_fuse.c                    |  4 ++--
>  src/openvz/openvz_driver.c            |  2 +-
>  src/qemu/qemu_command.c               |  6 +++---
>  src/qemu/qemu_domain.c                |  2 +-
>  src/qemu/qemu_hotplug.c               |  2 +-
>  src/security/security_manager.c       |  2 +-
>  src/security/security_selinux.c       | 12 ++++++------
>  src/storage/storage_backend_logical.c |  2 +-
>  src/util/virfile.c                    |  2 +-
>  src/util/virsystemd.c                 |  2 +-
>  src/vz/vz_driver.c                    |  2 +-
>  src/vz/vz_sdk.c                       |  2 +-
>  src/xen/xend_internal.c               |  2 +-
>  src/xenconfig/xen_sxpr.c              |  2 +-
>  tests/commandtest.c                   | 10 +++++-----
>  tests/securityselinuxlabeltest.c      |  2 +-
>  tests/virauthconfigtest.c             |  2 +-
>  tests/virbitmaptest.c                 | 12 ++++++------
>  tests/vircgrouptest.c                 |  2 +-
>  tests/virkeyfiletest.c                |  8 ++++----
>  tests/virnetsockettest.c              |  2 +-
>  tests/virtypedparamtest.c             |  2 +-
>  tests/viruritest.c                    | 16 ++++++++--------
>  28 files changed, 56 insertions(+), 56 deletions(-)
> 
> diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
> index d44cf2c..e5d56e9 100644
> --- a/src/bhyve/bhyve_driver.c
> +++ b/src/bhyve/bhyve_driver.c
> @@ -197,7 +197,7 @@ bhyveConnectOpen(virConnectPtr conn,
>           if (conn->uri->server)
>               return VIR_DRV_OPEN_DECLINED;
> 
> -         if (!STREQ_NULLABLE(conn->uri->path, "/system")) {
> +         if (STRNEQ_NULLABLE(conn->uri->path, "/system")) {
>              virReportError(VIR_ERR_INTERNAL_ERROR,
>                             _("Unexpected bhyve URI path '%s', try
> bhyve:///system"),
>                             conn->uri->path);


This patch seems corrupt, can you please resend using 'git send-email'?
Also, it would be good if you can merge those two patches into a single
one. It's not necessary though.

Michal




More information about the libvir-list mailing list