[libvirt] [PATCH 07/10] qemu: domain: Remove memory device check from post parse callback

[John Ferlan]

On 10/16/2015 08:11 AM, Peter Krempa wrote:
> We check that <maxMemory> is present when we have memory devices at the
> time we start the VM or add the device, so we can remove it from the
> post parse callback to be more tolerant to users.
> ---
>  src/qemu/qemu_domain.c | 8 --------
>  1 file changed, 8 deletions(-)
> 

Hmm.. we never had a DO_TEST_PARSE_FAILURE test on this...

> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 1474a5b..a22e5ad 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -1347,14 +1347,6 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
>          }
>      }
> 
> -    if (dev->type == VIR_DOMAIN_DEVICE_MEMORY &&
> -        !virDomainDefHasMemoryHotplug(def)) {
> -        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> -                       _("maxMemory has to be specified when using memory "
> -                         "devices "));

Well at least I know where you got that error message in patch 5... it
almost feels as if this could be merged there to make it more obvious.

ACK - regardless of whether it's moved or not.

John
> -        goto cleanup;
> -    }
> -
>      ret = 0;
> 
>   cleanup:
>