[libvirt] [PATCH v2 0/2] tests: Add nodeinfo test data utility scripts
abologna at redhat.com
Thu Oct 22 12:43:09 UTC 2015
On Thu, 2015-10-22 at 13:27 +0200, Martin Kletzander wrote:
> > > As for patch 2, one would have to know they should use the
> > > copy-from-host.sh script. Perhaps what might be better and/or
> > > somewhat
> > > more interesting on this one is some make check rule that scans
> > > the
> > > nodeinfodata trees looking for files that shouldn't be there.
> > > That
> > > way
> > > if someone does use their own methodology to copy over the tree
> > > we'd
> > > know it (and could message to use the copy-from-host.sh script...
> > I agree, as it stands it's not very discoverable, plus
> > adding the check you suggest would also prevent something
> > like e739d95 from ever being needed again.
> > I'll work on that as soon as I have some time.
> Maybe simple .gitignore entry would suffice.
Problem is, .gitignore works well if you have the list of
files you want to avoid, but we have the complementary
information: the list of files we want to keep.
Software Engineer - Virtualization Team
More information about the libvir-list