[libvirt] [PATCH 00/10] Allow memory hotplug without NUMA on ppc64

[Shivaprasad bhat]

Hi Peter,

Went through the series and gave a try. The series looks good.

One thing I wonder, should we allow the dimms without targetNode info
in the xml be hotplugged when
the guest is actually configured with NUMA nodes ? The current series
does allow it. What is your take ?

Thanks,
Shiva

On Fri, Oct 16, 2015 at 5:41 PM, Peter Krempa <pkrempa at redhat.com> wrote:
> Peter Krempa (10):
>   conf: Make @def const in virDomainDefGetMemoryInitial
>   conf: Turn targetNode in struct virDomainMemoryDef to signed
>   qemu: command: Make qemuBuildMemoryBackendStr usable without NUMA
>   qemu: command: Always execute memory device formatter
>   qemu: domain: Add common function to perform memory hotplug checks
>   qemu: command: Move dimm device checks from formatter to checker
>   qemu: domain: Remove memory device check from post parse callback
>   conf: Prepare making memory device target node optional
>   qemu: command: Prepare memory device def formatter for missing target
>     node
>   qemu: ppc64: Support memory hotplug without NUMA enabled
>
>  docs/formatdomain.html.in                          |   5 +-
>  docs/schemas/domaincommon.rng                      |   8 +-
>  src/conf/domain_conf.c                             |  18 ++-
>  src/conf/domain_conf.h                             |   4 +-
>  src/qemu/qemu_command.c                            | 143 +++++------------
>  src/qemu/qemu_command.h                            |   4 +-
>  src/qemu/qemu_domain.c                             | 177 ++++++++++++++++++++-
>  src/qemu/qemu_domain.h                             |   4 +
>  src/qemu/qemu_hotplug.c                            |  11 +-
>  .../qemuxml2argv-memory-hotplug-ppc64-nonuma.args  |  19 +++
>  .../qemuxml2argv-memory-hotplug-ppc64-nonuma.xml   |  38 +++++
>  tests/qemuxml2argvtest.c                           |   2 +
>  12 files changed, 296 insertions(+), 137 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-ppc64-nonuma.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-ppc64-nonuma.xml
>
> --
> 2.4.5
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list