[libvirt] [PATCH] domain-conf: reorder usb controllers so the master is first

Ján Tomko jtomko at redhat.com
Tue Oct 27 08:15:56 UTC 2015

On Mon, Oct 26, 2015 at 05:28:21PM +0100, Pavel Hrdina wrote:
> USB controllers can share the same 'index' which indicates, that there
> is some sort of master-companion relationship.  Reorder the controllers
> in XML in to place the master controller before its companions.  This is
> required by QEMU to not fail with error message:
> error: internal error: process exited while connecting to monitor:
> 2015-10-26T16:25:17.630265Z qemu-system-x86_64:
> -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pci.0,multifunction=on,addr=0x6:
> USB bus 'usb.0' not found
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1166452
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/conf/domain_conf.c | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)

Makes sense, but the patch would look better with -b if the
non-functional changes were separate.
A test case would be nice too.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151027/dda82bb7/attachment-0001.sig>

More information about the libvir-list mailing list