[libvirt] [PATCH] locking: Add io_timeout to sanlock

Martin Kletzander mkletzan at redhat.com
Tue Oct 27 09:23:01 UTC 2015


On Fri, Oct 23, 2015 at 01:37:54PM +0200, Michal Privoznik wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1251190
>
>So, if domain loses access to storage, sanlock tries to kill it
>after some timeout. So far, the default is 80 seconds. But for
>some scenarios this might not be enough. We should allow users to
>adjust the timeout according to their needs.
>

Shouldn't we check for whether the current sanlock version supports
that?  Or require new enough version in configure/libvirt.spec?  I
understand the _timeout option was added later then the previous one.

Otherwise looks good, if you convince me that there is no need for the
check then it can go in as it is.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151027/cdbb2bd8/attachment-0001.sig>


More information about the libvir-list mailing list