[libvirt] [PATCH] conf: Add serial target type to ABI stability check

[Martin Kletzander]

On Wed, Oct 21, 2015 at 03:14:03PM +0800, Luyao Huang wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1273686
>
>There is no ABI check for serial target type attribute, just
>add it.
>
>Signed-off-by: Luyao Huang <lhuang at redhat.com>
>---
> src/conf/domain_conf.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>

ACK && Pushed

>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 02cc8ad..a31bc05 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -17225,6 +17225,14 @@ static bool
> virDomainSerialDefCheckABIStability(virDomainChrDefPtr src,
>                                     virDomainChrDefPtr dst)
> {
>+    if (src->targetType != dst->targetType) {
>+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>+                       _("Target serial type %s does not match source %s"),
>+                       virDomainChrSerialTargetTypeToString(dst->targetType),
>+                       virDomainChrSerialTargetTypeToString(src->targetType));
>+        return false;
>+    }
>+
>     if (src->target.port != dst->target.port) {
>         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                        _("Target serial port %d does not match source %d"),
>--
>1.8.3.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151027/4cb1fb76/attachment-0001.sig>