[libvirt] [PATCH] conf: Add serial target type to ABI stability check

[lhuang]

On 10/27/2015 05:45 PM, Martin Kletzander wrote:
> On Wed, Oct 21, 2015 at 03:14:03PM +0800, Luyao Huang wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1273686
>>
>> There is no ABI check for serial target type attribute, just
>> add it.
>>
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>> src/conf/domain_conf.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>
> ACK && Pushed

Thanks a lot for your review.

Luyao

>
>> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>> index 02cc8ad..a31bc05 100644
>> --- a/src/conf/domain_conf.c
>> +++ b/src/conf/domain_conf.c
>> @@ -17225,6 +17225,14 @@ static bool
>> virDomainSerialDefCheckABIStability(virDomainChrDefPtr src,
>>                                     virDomainChrDefPtr dst)
>> {
>> +    if (src->targetType != dst->targetType) {
>> +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>> +                       _("Target serial type %s does not match 
>> source %s"),
>> + virDomainChrSerialTargetTypeToString(dst->targetType),
>> + virDomainChrSerialTargetTypeToString(src->targetType));
>> +        return false;
>> +    }
>> +
>>     if (src->target.port != dst->target.port) {
>>         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>>                        _("Target serial port %d does not match source 
>> %d"),
>> -- 
>> 1.8.3.1
>>
>> -- 
>> libvir-list mailing list
>> libvir-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list