[libvirt] [libvirt-glib] gobject: Add wrapper virDomainSetTime()

Christophe Fergeau cfergeau at redhat.com
Wed Oct 28 16:22:31 UTC 2015


On Wed, Oct 28, 2015 at 01:25:42PM +0000, Zeeshan Ali (Khattak) wrote:
> >
> > (flags & GVIR_DOMAIN_TIME_SYNC) != 0 to be consistent with the 'flags ==
> > 0' before. However, shouldn't it be flags & GVIR_DOMAIN_TIME_SYNC ==
> > GVIR_DOMAIN_TIME_SYNC to be sure we were not passed unknown flags?
> 
> Yeah, that sounds better.

Actually, this is not doing what I meant at all ;) should be flags ==
GVIR_DOMAIN_TIME_SYNC, or flags & ~GVIR_DOMAIN_TIME_SYNC == 0 if we want
to make sure we were only passed known flags.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151028/59b84d6a/attachment-0001.sig>


More information about the libvir-list mailing list