[libvirt] [PATCH v6 11/13] qemu: Block snapshot operation with RAID

Matthias Gatto matthias.gatto at outscale.com
Thu Oct 29 13:43:18 UTC 2015

For now we block all snapshot operations with quorum,
because it would require a lot more code,
especially because Qemu doesn't really suport it.

I guess, we can use node-name, and manually snapshot all qcow
from a virStorageSource and use this as a quorum's snapshot,
but libvirt doesn't support node-name, and we don't need
node-name anymore to use a quorum in qemu.

I have some patchs which could partially support quorum snapshot
on my computer, but nothing suitable to be upstream, so I prefer to have
a stable versions of quorum inside libvirt before dealing with

Signed-off-by: Matthias Gatto <matthias.gatto at outscale.com>
 src/qemu/qemu_driver.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 193c25d..1ec0cf2 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -14674,6 +14674,12 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
     if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
         goto cleanup;
+    if (virDomainDefHasRAID(vm->def)) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                       _("Snapshot does not support domain with RAID(like quorum) yet"));
+        goto cleanup;
+    }
     if (qemuProcessAutoDestroyActive(driver, vm)) {
                        "%s", _("domain is marked for auto destroy"));

More information about the libvir-list mailing list