[libvirt] [PATCH v2] domain-conf: escape string for socket attribute

[Martin Kletzander]

On Thu, Sep 03, 2015 at 05:42:37PM +0200, Pavel Hrdina wrote:
>Commit d091518b tried to escape all strings in produced XML, but missed
>this one.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/conf/domain_conf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 69225f4..f95190f 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -21118,9 +21118,7 @@ virDomainGraphicsDefFormat(virBufferPtr buf,
>     switch (def->type) {
>     case VIR_DOMAIN_GRAPHICS_TYPE_VNC:
>         if (def->data.vnc.socket) {
>-            if (def->data.vnc.socket)
>-                virBufferAsprintf(buf, " socket='%s'",
>-                                  def->data.vnc.socket);
>+            virBufferEscapeString(buf, " socket='%s'", def->data.vnc.socket);
>         } else {
>             if (def->data.vnc.port &&
>                 (!def->data.vnc.autoport || !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)))
>--
>2.5.1
>

ACK

>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150903/ed0d9e4c/attachment-0001.sig>