[libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()
jferlan at redhat.com
Thu Sep 3 20:55:59 UTC 2015
On 09/03/2015 01:40 PM, Jim Fehlig wrote:
> Remove redundant error reporting in libxlDomainMigrationPerform().
> virNetSocketNewConnectTCP() is perfectly capable of reporting
> sensible errors.
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> Actually try to compile the code and find saved_errno is no
> longer used - remove it.
> src/libxl/libxl_migration.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Also noteworthy that virNetSocketNewConnectTCP could overwrite errno
when freeaddrinfo is run in error: or when VIR_FORCE_CLOSE() did it's
More information about the libvir-list