[libvirt] [PATCH 0/4] Several virsh initialization adjustments
Erik Skultety
eskultet at redhat.com
Fri Sep 4 12:23:20 UTC 2015
On 04/09/15 13:47, Ján Tomko wrote:
> On Fri, Sep 04, 2015 at 01:10:02PM +0200, Erik Skultety wrote:
>> When looking at commit 4fdd873f, I've come to notice, that after my changes to
>> virsh (834c5720), vshInit always calls vshReadlineInit and that is because
>> client mode defaults to interactive which might be changed after command line
>> arguments are parsed. So this series addresses this minor issue and provides
>> some small tweaks and adjustments.
>>
>> Erik Skultety (4):
>> virsh: Do not make interactive mode default
>> vsh: adjust vshInit signature and remove redundant error label
>> vsh: Introduce vshInitReload
>> vsh: Make vshInitDebug static
>>
>> tools/virsh.c | 12 +++++++-----
>> tools/vsh.c | 32 ++++++++++++++++++++++----------
>> tools/vsh.h | 4 ++--
>> 3 files changed, 31 insertions(+), 17 deletions(-)
>
> ACK series
>
> Jan
>
Thanks for review, I fixed 3/4, moved 1/4 after 3/4 and pushed the series.
Erik
More information about the libvir-list
mailing list