[libvirt] [PATCH 0/5] Resolve some Coverity related errors

John Ferlan jferlan at redhat.com
Fri Sep 4 14:30:57 UTC 2015

Patches 1, 3, & 4 show up periodically in my Coverity runs, but not
always.  Usually only when some sort of self inflicted build error only
gets a partial build followed by a complete analysis phase.

Patch 2 is related to a Coverity error seen in private integration
testing as well. Although it could be deemed Coverity noise - it's
just easier to adjust our code to use the right type than try to
generate a reproducer or figure out exactly what the error is.

Patch 5 is based on some investigation I started in July to remove
some sa_asserts. I could split into two patches if really desired,
but it was just easier to keep as one.

John Ferlan (5):
  qemu: Check virGetLastError return value for migration finish failure
  lxc: Avoid Coverity SIZEOF_MISMATCH
  virfile: Avoid Coverity IDENTICAL_BRANCHES error
  util: Avoid Coverity FORWARD_NULL
  conf: Remove need for a couple of sa_asserts

 src/conf/domain_conf.c    | 9 +++++----
 src/libvirt-domain.c      | 3 ++-
 src/lxc/lxc_container.c   | 4 ++--
 src/qemu/qemu_migration.c | 3 ++-
 src/util/virdbus.c        | 4 ++++
 src/util/virfile.c        | 3 +--
 6 files changed, 16 insertions(+), 10 deletions(-)


More information about the libvir-list mailing list