[libvirt] [PATCH 1/2] qemuProcessStart: Parse backingStore for all disks

Peter Krempa pkrempa at redhat.com
Tue Sep 8 15:34:42 UTC 2015


On Tue, Sep 08, 2015 at 17:17:18 +0200, Michal Privoznik wrote:

Subject is misleading. Backing store is detected from disk images not
parsed from XML.

> Later, in the next commit, we are going to need backing chain
> for all the disks within the domain. Let's parse them at domain
> startup phase.

Why do we need this patch? Currently qemuDomainDetermineDiskChain still
gets called on all disks where it makes sense. Exceptions are:
1) empty drives (this is also redundant, since
qemuDomainDetermineDiskChain will check it again).

2) disk source formats that don't support backing chains, where we just
check that the file exists.

This patch would make us call that on those too.

NACK,

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150908/0f6563ff/attachment-0001.sig>


More information about the libvir-list mailing list