[libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

Lin Ma lma at suse.com
Wed Sep 9 03:04:03 UTC 2015


在 2015年09月08日 20:10, Peter Krempa 写道:
> On Wed, Sep 02, 2015 at 17:58:19 +0200, Michal Privoznik wrote:
>> From: Lin Ma <lma at suse.com>
>>
>> Format & output more detailed information about networked source
>>
>> e.g: The output without the patch:
>> $ virsh domblklist $DOMAIN --details
>> Type       Device     Target     Source
>> ------------------------------------------------
>> network    disk       vda        test-pool/image
>> network    disk       vdb        iqn.2015-08.org.example:sn01/0
>> network    disk       vdc        /image.raw
>> network    disk       vdd        -
>> network    disk       vde        -
>> network    disk       vdf        image1
>> network    disk       vdg        test-volume/image.raw
>>
>> The output with the patch:
>> $ virsh domblklist $DOMAIN --details
>> Type       Device     Target     Source
>> ------------------------------------------------
>> network    disk       vda        rbd://monitor1.example.org:6321/test-pool/image
> One other thing to note is that RBD volumes may have multiple hosts,
> which is not taken into account by the above format ...

Yes, It may have multiple hosts for rbd. My original idea was adding 
more specific
info to details option for networked source and make the output more nice.

It has nothing to do with functional changes, So it just shows the first 
host.
Should we bring all of hosts to here?

>> network    disk       vdb        iscsi://192.168.124.200:3260/iqn.2015-08.org.example:sn01/0
>> network    disk       vdc        http://192.168.124.200:80/image.raw
>> network    disk       vdd        nbd+unix:///var/run/nbdsock
>> network    disk       vde        nbd://192.168.124.200:12345
>> network    disk       vdf        sheepdog://192.168.124.200:6000/image1
>> network    disk       vdg        gluster://192.168.124.200/test-volume/image.raw
> ... and gluster volumes will possibly have multiple sources too.
>
>> Signed-off-by: Lin Ma <lma at suse.com>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>   tools/virsh-domain-monitor.c | 64 ++++++++++++++++++++++++++++++++++++++++----
>>   1 file changed, 59 insertions(+), 5 deletions(-)
> Peter
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150909/86306e1c/attachment-0001.htm>


More information about the libvir-list mailing list