[libvirt] [PATCH 2/3] Use mockup cache

Pavel Fedin p.fedin at samsung.com
Wed Sep 9 13:37:18 UTC 2015


> Looks good to me, but domainsnapshotxml2xmltest crashes with this series
> applied.

 Aaarrgh... I am leaving for vacation, so not sure if i'll be able to correct it today. After 2
weeks i guess...

> Can this be done in qemuTestDriverInit instead? It seems most of the
> test need the cache to be initialized, but only a few need to create
> their custom capabilities.

> This cache is tied to the test name, so it will only be used once.
> We should probably remove it afterwards, there's no need to keep >500
> entries in a hash table of size 10.

 If you read the cover letter carefully, then you should know that the final intention is to be able
to exploit an XML cache and completely remove hardcoded sets. When this is done, custom insert
function will go away too. And of course there'll be no delete. I guess name of capabilities set
would differ from test name, and the same set would be reused across tests which need equal

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

More information about the libvir-list mailing list