[libvirt] [PATCH] Revert "qemu: Fix integer/boolean logic in qemuSetUnprivSGIO"
Ján Tomko
jtomko at redhat.com
Tue Sep 22 14:28:50 UTC 2015
On Fri, Sep 18, 2015 at 03:56:34PM -0400, John Ferlan wrote:
> This reverts commit 69b850fe2a19d0c32ae2f209e8d8463df6ead665.
>
> This change broke the ability to "clear" or reset unfiltered back
> to filtered.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>
> This is a <facepalm> event - have to wonder what I was thinking
> at the time. The patch pushed removes the ability to actually
> clear the value in the file. Although it's possible to check what's
> in the file first, it's still important to "attempt" the check if
> someone set sgio on a disk and unpriv_sgio isn't supported. So, just
> reverting this restores the former functionality of setting to
> either 0 or 1.
>
> src/qemu/qemu_conf.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
ACK
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150922/2a99cbc9/attachment-0001.sig>
More information about the libvir-list
mailing list