[libvirt] [PATCH] spec: Fix some warnings with latest rpmbuild
Eric Blake
eblake at redhat.com
Tue Sep 22 20:40:31 UTC 2015
On 09/22/2015 01:57 PM, Cole Robinson wrote:
> $ rpmbuild -ba libvirt.spec
> warning: Macro expanded in comment on line 5: # If neither fedora nor rhel was defined, try to guess them from %{dist}
>
> warning: Macro %enable_autotools defined but not used within scope
> warning: Macro %client_only defined but not used within scope
> ...
> ---
> libvirt.spec.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> # Default to skipping autoreconf. Distros can change just this one line
> # (or provide a command-line override) if they backport any patches that
> # touch configure.ac or Makefile.am.
> -%{!?enable_autotools:%define enable_autotools 0}
> +%{!?enable_autotools:%global enable_autotools 0}
I guess %global works. I might have tried:
%if !0%{?enable_autotools}
%define enable_autotools 0
%endif
but that's longer.
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150922/f94d9471/attachment-0001.sig>
More information about the libvir-list
mailing list