[libvirt] [libvirt-sandbox][PATCH 1/4] builder: Drop dead code in gvir_sandbox_builder_clean_post_stop

Michal Privoznik mprivozn at redhat.com
Wed Sep 23 09:15:21 UTC 2015


At the 'cleanup' label we try to unref @child. However, whenever
the label is entered there's no chance for the variable to be
anything else than NULL rendering those two lines as dead code.
Drop it. And it's the same story with @info.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 libvirt-sandbox/libvirt-sandbox-builder.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libvirt-sandbox/libvirt-sandbox-builder.c b/libvirt-sandbox/libvirt-sandbox-builder.c
index ea7d064..b4b4d77 100644
--- a/libvirt-sandbox/libvirt-sandbox-builder.c
+++ b/libvirt-sandbox/libvirt-sandbox-builder.c
@@ -752,10 +752,6 @@ gboolean gvir_sandbox_builder_clean_post_stop(GVirSandboxBuilder *builder,
         ret = FALSE;
 
  cleanup:
-    if (child)
-        g_object_unref(child);
-    if (info)
-        g_object_unref(info);
     g_object_unref(enumerator);
     g_object_unref(libsFile);
     g_free(libsdir);
-- 
2.4.9




More information about the libvir-list mailing list