[libvirt] [PATCH] add compress stream support

Vasiliy Tolstov v.tolstov at selfip.ru
Wed Sep 23 12:20:51 UTC 2015

2015-09-23 14:54 GMT+03:00 Daniel P. Berrange <berrange at redhat.com>:
> How have you actually tested this in practice - your patch does
> not change any code to make use of this new feate. You're changing
> the public API which suggests you expect the client apps to use
> this when passing a virStreamPtr to the virStorageVolDownload
> method, but the stream client apps pass is not backed by a
> virFDStream object. Only libvirtd uses the virFDSteam objects
> and you've not changed anything to make use ot that. So this is
> all rather strange still. Can you more clearly state what you
> are expecting to do.

As i'm understand client create stream via virStreamNew , when user
invoke virStoreVolDownload this function use created stream.
If i'm correct, libvirt when read/write in
virStoreVolDownload/virStoreVolUpload uses fdstream functions
internally. So data compressed or decompressed.
Or when client create virStreamNew and pass it libvirt not always use
fdstream functions ?

Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru

More information about the libvir-list mailing list