[libvirt] [PATCH v2] qemuDomainDeviceDefPostParse: Drop useless checks

John Ferlan jferlan at redhat.com
Wed Sep 23 22:03:47 UTC 2015

On 09/23/2015 07:19 AM, Michal Privoznik wrote:
> Now that virQEMUDriverCreateXMLConf is never called with NULL
> (after 086f37e97aab) we can safely drop useless check in
> qemuDomainDeviceDefPostParse as we are guaranteed to be always
> called with the driver initialized. Therefore checking if driver
> is NULL makes no sense. Moreover, if we mix it with direct driver
> dereference. And after that, we are sure that nor @cfg will be
> NULL, therefore we can drop checks for that too.
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> diff to v1:
> - drop checks for !cfg too
>  src/qemu/qemu_domain.c | 64 ++++++++++++++++++++------------------------------
>  1 file changed, 26 insertions(+), 38 deletions(-)



Coverity error goes away too.

More information about the libvir-list mailing list