[libvirt] [PATCH 4/6] virsh: Resolve Coverity DEADCODE

John Ferlan jferlan at redhat.com
Thu Sep 24 13:42:43 UTC 2015



On 09/24/2015 03:47 AM, Ján Tomko wrote:
> On Wed, Sep 23, 2015 at 07:18:31PM -0400, John Ferlan wrote:
>> Use 'dead_error_condition' instead of 'dead_error_begin'
>>
> 
> Just wondering - what is the difference?

Perhaps just the one condition and not a set of conditions or lines? Not
quite sure, but you know where to find the internal output and you'll
see the data spewed by Coverity about the deadcode.

> Doesn't dead_error_begin require a dead_error_end?

No - once it's dead, it's not coming back to life.

John

> 
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>  tools/virsh.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK.
> 
> Jan
> 




More information about the libvir-list mailing list