[libvirt] [FIRST-PATCH] updated the negation STREQ to STRNEQ

[Lasya Venneti]

Dear Sir,
The cfg.mk link isn't working for me sir..
>From what I understand Makefile will have the following:

target: dependency1 dependency2 ...
[TAB] action1
[TAB] action2

Does the syntax-check rule have to be in place of 'actions' in the form of
a shell command, and then raise an error whenever the shell command returns
occurrences of the string !STREQ or !STRNEQ ? Request you to please
elaborate a little.


Sincerely,
Lasya V

On 21 September 2015 at 16:35, Michal Privoznik <mprivozn at redhat.com> wrote:

> [You've got the wrong list. This is a libvirt patch and as such it
> should have been sent to the libvir-list at redhat.com]
>
> On 19.09.2015 16:59, Lasya wrote:
> > Hi,
> > This is my first patch in QEMU. I have solved a bite-sized bug. I have
> updated the !STREQ with STRNEQ in the following files. Thanks.
> >
> > ---
> >  src/bhyve/bhyve_driver.c              |  2 +-
> >  src/conf/network_conf.c               |  4 ++--
> >  src/conf/nwfilter_conf.c              |  2 +-
> >  src/conf/nwfilter_params.c            |  2 +-
> >  src/conf/storage_conf.c               |  2 +-
> >  src/lxc/lxc_fuse.c                    |  4 ++--
> >  src/openvz/openvz_driver.c            |  2 +-
> >  src/qemu/qemu_command.c               |  6 +++---
> >  src/qemu/qemu_domain.c                |  2 +-
> >  src/qemu/qemu_hotplug.c               |  2 +-
> >  src/security/security_manager.c       |  2 +-
> >  src/security/security_selinux.c       | 12 ++++++------
> >  src/storage/storage_backend_logical.c |  2 +-
> >  src/util/virfile.c                    |  2 +-
> >  src/util/virsystemd.c                 |  2 +-
> >  src/vz/vz_driver.c                    |  2 +-
> >  src/vz/vz_sdk.c                       |  2 +-
> >  src/xen/xend_internal.c               |  2 +-
> >  src/xenconfig/xen_sxpr.c              |  2 +-
> >  tests/commandtest.c                   | 10 +++++-----
> >  tests/securityselinuxlabeltest.c      |  2 +-
> >  tests/virauthconfigtest.c             |  2 +-
> >  tests/virbitmaptest.c                 | 12 ++++++------
> >  tests/vircgrouptest.c                 |  2 +-
> >  tests/virkeyfiletest.c                |  8 ++++----
> >  tests/virnetsockettest.c              |  2 +-
> >  tests/virtypedparamtest.c             |  2 +-
> >  tests/viruritest.c                    | 16 ++++++++--------
> >  28 files changed, 56 insertions(+), 56 deletions(-)
>
> Okay, you've got all the occurrences. However, the syntax-check rule is
> missing. You may want to look at cfg.mk for some examples. syntax-check
> is our make target that checks the code if it complies with our coding
> standards. After this patch we want a rule that forbids !STREQ or !STRNEQ.
>
> Otherwise looking very good. Looking forward to v2.
>
> Michal
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150924/384072b5/attachment-0001.htm>