[libvirt] [PATCH v3 01/14] migration: refactor: get rid of use_params p2p_full

Jiri Denemark jdenemar at redhat.com
Fri Sep 25 14:12:38 UTC 2015


On Fri, Sep 18, 2015 at 18:05:39 +0300, Nikolay Shirokovskiy wrote:
> 'useParams' parameter usage is an example of control coupling. Most of the work
> inside the function is done differently except for the uri check. Lets split
> this function into two, one with extensible parameters set and one with hardcoded
> parameter set.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>  src/libvirt-domain.c |  103 +++++++++++++++++++++++--------------------------
>  1 files changed, 48 insertions(+), 55 deletions(-)

ACK

Jirka




More information about the libvir-list mailing list