[libvirt] [PATCH] qemu: Fix dynamic_ownership qemu.conf setting
Cole Robinson
crobinso at redhat.com
Tue Sep 29 12:28:22 UTC 2015
On 09/29/2015 12:46 AM, Martin Kletzander wrote:
> On Mon, Sep 28, 2015 at 07:53:42PM -0400, Cole Robinson wrote:
>> Commit 307fb904 (Sep 10) added a 'privileged' variable when creating
>> the DAC driver:
>>
>> @@ -153,6 +157,7 @@ virSecurityManagerNewDAC(const char *virtDriver,
>> bool defaultConfined,
>> bool requireConfined,
>> bool dynamicOwnership,
>> + bool privileged,
>> virSecurityManagerDACChownCallback chownCallback)
>>
>> But argument order is mixed up at the caller, swapping dynamicOwnership
>> and privileged values. This corrects the argument order
>>
>
> I'm pretty sure I noticed this during review. I must've failed to
> inform the author because I see no reply to the patch that caused it.
>
> ACK and safe for freeze!
>
Thanks, pushed now
- Cole
More information about the libvir-list
mailing list