[libvirt] [PATCH v2 00/10] Introduce worker tuning APIs

[Michal Privoznik]

On 29.03.2016 09:51, Erik Skultety wrote:
> NOTE: patch 2/10 moves typed params definition from libvirt-host.h to
> libvirt-common.h.in to enable it for admin as well -> therefore
> libvirt-common.h must be regenerated with config.status
> 
> - also I'd like to open a discussion about virt-admin commands naming, since
> I was sort of of out ideas when I copied numatune,memtune,etc. design into
> "workertune"; I thought about srv-threadpool-info and srv-threadpool-set to
> be a little consistent with srv-list, but for some reason I found it quite
> long-ish so I dropped that...
> 
> v2:
> - repost of v1 due to rebase conflicts
> - due to rebase conflicts and overall changes since the original v1
> po/POTFILES.in (patch 1/10) had to be updated
> 
> Erik Skultety (10):
>   po: Fix record ordering in POTFILES.in
>   libvirt-host: Move virTypedParam* to libvirt-common
>   admin: Enable usage of typed parameters
>   util: Refactor thread creation by introducing virThreadPoolExpand
>   util: Report system error when virThreadCreateFull fails
>   util: Add more getters to threadpool parameters
>   admin: Prepare admin protocol for future worker related procedures
>   admin: Introduce virAdmServerGethreadPoolParameters
>   admin: Introduce virAdmServerSetThreadPoolParameters
>   virt-admin: Introduce srv-workertune command
> 
>  cfg.mk                              |   2 +-
>  daemon/admin.c                      | 102 +++++++++++++++++++
>  daemon/admin_server.c               | 112 +++++++++++++++++++++
>  daemon/admin_server.h               |  11 ++
>  include/libvirt/libvirt-admin.h     |  71 +++++++++++++
>  include/libvirt/libvirt-common.h.in | 185 ++++++++++++++++++++++++++++++++++
>  include/libvirt/libvirt-host.h      | 186 ----------------------------------
>  po/POTFILES.in                      |   4 +-
>  src/admin/admin_protocol.x          |  54 +++++++++-
>  src/admin/admin_remote.c            |  77 ++++++++++++++
>  src/admin_protocol-structs          |  45 +++++++++
>  src/libvirt-admin.c                 |  83 +++++++++++++++
>  src/libvirt_admin_private.syms      |   3 +
>  src/libvirt_admin_public.syms       |   2 +
>  src/libvirt_private.syms            |   4 +
>  src/rpc/virnetserver.c              |  37 +++++++
>  src/rpc/virnetserver.h              |  13 +++
>  src/util/virthreadpool.c            | 196 ++++++++++++++++++++++++------------
>  src/util/virthreadpool.h            |   8 ++
>  tools/virt-admin.c                  | 132 ++++++++++++++++++++++++
>  20 files changed, 1073 insertions(+), 254 deletions(-)
> 

My overall feeling is good. But some patches need to be polished in v3.

Michal