[libvirt] [PATCH] configure: Fix check for --with-login-shell on Windows

[Cole Robinson]

On 04/08/2016 10:55 AM, Andrea Bolognani wrote:
> The check is supposed to stop users from trying to compile
> virt-login-shell on Windows by erroring out during the
> configure phase; however, there are two flaws in it:
> 
>   * the value of "x$with_win" is compared to "yes" instead
>     of "xyes" (note the "x" in the first string)
> 
>   * "test" is not being used, so the script will actually
>     try to run a command called "x$with_win" instead of
>     performing string comparison
> 
> This patch fixes both issues.
> ---
>  m4/virt-login-shell.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4
> index c77ffb5..d5e2e00 100644
> --- a/m4/virt-login-shell.m4
> +++ b/m4/virt-login-shell.m4
> @@ -22,7 +22,7 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [
>  
>    if test "x$with_login_shell" != "xno"; then
>      if test "x$with_win" = "xyes"; then
> -      if "x$with_login_shell" = "yes"; then
> +      if test "x$with_login_shell" = "xyes"; then
>          AC_MSG_ERROR([virt-login-shell is not supported on Windows])
>        else
>          with_login_shell=no;
> 

ACK

- Cole