[libvirt] [PATCH] domain_conf: fix graphics parsing

Peter Krempa pkrempa at redhat.com
Mon Apr 11 11:50:24 UTC 2016


On Mon, Apr 11, 2016 at 13:37:16 +0200, Pavel Hrdina wrote:
> Commit dc98a5bc refactored the code a lot and forget about checking if
> listen attribute is specified.  This ensures that listen attribute and
> first listen element are compared only if both exist.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/conf/domain_conf.c                             |  3 +-
>  .../qemuxml2argv-graphics-vnc-no-listen-attr.args  | 22 ++++++++++++
>  .../qemuxml2argv-graphics-vnc-no-listen-attr.xml   | 36 +++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  1 +
>  .../qemuxml2xmlout-graphics-vnc-no-listen-attr.xml | 41 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  1 +
>  6 files changed, 103 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-no-listen-attr.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-no-listen-attr.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-no-listen-attr.xml

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160411/327fc0a3/attachment-0001.sig>


More information about the libvir-list mailing list