[libvirt] [PATCH 4/4] cfg.mk: Always enclose syntax-check error messages in quotes

Andrea Bolognani abologna at redhat.com
Tue Apr 12 09:37:58 UTC 2016


On Tue, 2016-04-12 at 08:47 +0200, Peter Krempa wrote:
> On Mon, Apr 11, 2016 at 17:32:46 +0200, Andrea Bolognani wrote:
> > 
> > To prevent the error messages in cfg.mk from triggering the very
> > same rules they're supposed to explain, we split the message in
> > the middle of a symbol name.
> > 
> > In some cases we end up with something like
> > 
> >   'I am a me'ssage
> > 
> > However, using a little more punctuation and ensuring the message
> > is properly enclosed in quotes is nicer.
> > ---
> > A more proper fix is arguably to exclude cfg.mk from these specific
> > checks... It's not like we're going to use asprintf() in a Makefile
> > anyway.
> 
> I've actually thought it's done this way ...

I've pushed all other patches (thank for reviewing them!) but
not this one since I wanted to give the other approach a go.

I'll send the alternative version right away, please take a
look at it.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list