[libvirt] [PATCH 00/10] conf: disk xml parser refactors

Peter Krempa pkrempa at redhat.com
Tue Apr 12 13:55:34 UTC 2016


I unfortunately looked at this function. I did not like what I've seen.
Let's start making it a bit more bearable.

This series starts splitting and cleaning up virDomainDiskDefParseXML which is
an unmaintainable spaghettti-code mess currently.

Peter Krempa (10):
  util: Rename and move virStrIsPrint to virStringIsPrintable
  conf: disk: Don't initialize fields allocated by calloc
  conf: disk: Remove one unnecessary level of indentation
  conf: disk: Extract iotune parsing into a separate func
  conf: disk: Remove error label from virDomainDiskDefIotuneParse
  conf: virDomainDiskDefIotuneParse: simplfiy parsing
  conf: virDomainDiskDefIotuneParse: Report malformed number errors
  conf: disk: Split out parsing of disk mirror data
  conf: Refactor virDomainDiskDefMirrorParse
  conf: extract disk geometry parsing code

 src/conf/domain_conf.c   | 777 ++++++++++++++++++++++-------------------------
 src/libvirt_private.syms |   2 +-
 src/util/virstring.c     |  18 ++
 src/util/virstring.h     |   2 +
 src/util/virutil.c       |  12 -
 src/util/virutil.h       |   2 -
 6 files changed, 377 insertions(+), 436 deletions(-)

-- 
2.8.0




More information about the libvir-list mailing list