[libvirt] [PATCH 1/4] drop qemuBuildCommandLineCallbacks

Peter Krempa pkrempa at redhat.com
Wed Apr 13 08:13:07 UTC 2016


On Wed, Apr 13, 2016 at 09:51:38 +0200, Ján Tomko wrote:
> Essentially revert commit 3a6204c which added these to allow the test
> suite to pass without depending on the host system state.
> 
> Since commit 4b527c1 we already mock virSCSIDeviceGetSgName, so these
> callbacks are useless.
> ---
>  src/qemu/qemu_command.c | 35 +++++++++++------------------------
>  src/qemu/qemu_command.h | 18 ++----------------
>  src/qemu/qemu_hotplug.c |  3 +--
>  src/qemu/qemu_process.c |  3 +--
>  tests/testutilsqemu.c   | 19 -------------------
>  tests/testutilsqemu.h   |  1 -
>  6 files changed, 15 insertions(+), 64 deletions(-)
> 

ACK I'm glad it's gone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160413/16adf35a/attachment-0001.sig>


More information about the libvir-list mailing list