[libvirt] [PATCH] tests: Fix VIR_TEST_REGENERATE_OUTPUT

[Ján Tomko]

On Tue, Apr 12, 2016 at 08:54:59PM -0400, Laine Stump wrote:
> On 04/12/2016 06:33 PM, Cole Robinson wrote:
> > commit 950a90d489 mocked some virCommand handling for the qemu tests,
> > but we were using that in the test suite to call test-wrap-argv.pl for
> > regenerating test output.
> >
> > Switch the generator code to just use system() instead
> > ---
> 
> I dislike giving up the potential utility of virCommand*() in tests, but 
> this does fix the problem (without creating the inefficiency of an extra 
> function in the callstack for every virCommandRun() call by every 
> libvirtd in the world). So ACK unless someone has a better idea / 
> different opinion. (But there's one thing to fix, noted below).
> 

I proposed moving the offending caller to virnetdev.c and mocking it
instead of virCommand run in:

  cover.1460536848.git.jtomko at redhat.com
[libvirt] [PATCH 0/2] Fix VIR_TEST_REGENERATE_OUTPUT in tests

Jan