[libvirt] [PATCH 0/2] Fix VIR_TEST_REGENERATE_OUTPUT in tests

Cole Robinson crobinso at redhat.com
Wed Apr 13 12:50:20 UTC 2016


On 04/13/2016 07:00 AM, Peter Krempa wrote:
> On Wed, Apr 13, 2016 at 10:43:05 +0200, Ján Tomko wrote:
>> Instead of the proper solution of moving all the host-changing
>> stuff out of qemuBuildCommandLine, separate one helper
>> for easier mocking.
> 
> While the new placement of the helper might seem weird I quite like that
> we don't longer mock virCommandRun in this case.
> 
> So ACK series from my side unless anybody else objects.
> 

ACK as well (though maybe i'll resend my patch that uses system() anyways, it
greatly simplifies the Regenerate function)

- Cole




More information about the libvir-list mailing list