[libvirt] [PATCH] fix build by correcting functions order and src/Makefile.am

Maxim Nestratov mnestratov at virtuozzo.com
Thu Apr 14 00:23:08 UTC 2016


commit 30c61901 added new functions to libvirt_private.syms
not alpabetically sorted and erroneously added vz sources to
STATEFUL_DRIVER_SOURCE_FILES, which triggered check-aclrules
running while vz driver isn't ready for it yet.

Pushing under build-breaker rule.

---
  src/Makefile.am          |  1 -
  src/libvirt_private.syms | 12 ++++++------
  2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 08ff301..f5e57c0 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -630,7 +630,6 @@ DRIVER_SOURCE_FILES = \
         $(NULL)

  STATEFUL_DRIVER_SOURCE_FILES = \
-       $(VZ_DRIVER_SOURCES) \
         $(BHYVE_DRIVER_SOURCES) \
         $(INTERFACE_DRIVER_SOURCES) \
         $(LIBXL_DRIVER_SOURCES) \
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 1bcb3af..a9025f5 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -916,6 +916,11 @@ virCPUx86MakeData;

  # datatypes.h
  virConnectClass;
+virConnectCloseCallbackDataCall;
+virConnectCloseCallbackDataClass;
+virConnectCloseCallbackDataGetCallback;
+virConnectCloseCallbackDataRegister;
+virConnectCloseCallbackDataUnregister;
  virDomainClass;
  virDomainSnapshotClass;
  virGetConnect;
@@ -929,20 +934,15 @@ virGetSecret;
  virGetStoragePool;
  virGetStorageVol;
  virGetStream;
-virConnectCloseCallbackDataGetCallback;
-virNewConnectCloseCallbackData;
-virConnectCloseCallbackDataUnregister;
-virConnectCloseCallbackDataRegister;
-virConnectCloseCallbackDataCall;
  virInterfaceClass;
  virNetworkClass;
+virNewConnectCloseCallbackData;
  virNodeDeviceClass;
  virNWFilterClass;
  virSecretClass;
  virStoragePoolClass;
  virStorageVolClass;
  virStreamClass;
-virConnectCloseCallbackDataClass;


  # fdstream.h
--
2.4.3




More information about the libvir-list mailing list