[libvirt] [PATCH] storage: mpath: Don't error on target_type=NULL

Martin Kletzander mkletzan at redhat.com
Thu Apr 14 07:50:14 UTC 2016


On Wed, Apr 13, 2016 at 05:35:13PM -0400, Cole Robinson wrote:
>We use device-mapper to enumerate all dm devices, and filter out
>the list of multipath devices by checking the target_type string
>name. The code however cancels all scanning if we encounter
>target_type=NULL
>
>I don't know how to reproduce that situation, but a user was hitting
>it in their setup, and inspecting the lvm2/device-mapper code shows
>many places where !target_type is explicitly ignored and processing
>continues on to the next device. So I think we should do the same
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1069317
>---
> src/storage/storage_backend_mpath.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>

I don't see why we couldn't do that, ACK.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160414/8148964d/attachment-0001.sig>


More information about the libvir-list mailing list