[libvirt] [PATCH 10/10] secret: Move and rename secretLoadAllConfigs

Cole Robinson crobinso at redhat.com
Mon Apr 18 21:48:21 UTC 2016


On 03/02/2016 01:55 PM, John Ferlan wrote:
> Move to secret_conf.c and rename to virSecretLoadAllConfigs. Also includes
> moving/renaming the supporting virSecretLoad, virSecretLoadValue, and
> virSecretLoadValidateUUID.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/secret_conf.c     | 175 +++++++++++++++++++++++++++++++++++++++++++++
>  src/conf/secret_conf.h     |   3 +
>  src/libvirt_private.syms   |   1 +
>  src/secret/secret_driver.c | 174 +-------------------------------------------
>  4 files changed, 181 insertions(+), 172 deletions(-)

ACK, mirrors network_conf.c layout.

(though honestly I'd rather we have separate files for XML handling and object
handling... the existing conf.c files are too large anyways. I put an entry on
the LibvirtFirstBugs wiki page about that type of code reorg though it's
probably over an initial contributors head)

- Cole




More information about the libvir-list mailing list