[libvirt] [PATCH 12/10] secret: Introduce virSecretObjSaveConfig and virSecretObjSaveData

Cole Robinson crobinso at redhat.com
Mon Apr 18 22:12:30 UTC 2016


On 03/08/2016 12:36 PM, John Ferlan wrote:
> Move and rename the secretRewriteFile, secretSaveDef, and secretSaveValue
> from secret_driver to secret_conf
> 
> Need to make some slight adjustments since the secretSave* functions
> called secretEnsureDirectory, but otherwise mostly just a move of code.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/secret_conf.c     | 69 +++++++++++++++++++++++++++++++++++
>  src/conf/secret_conf.h     |  4 +++
>  src/libvirt_private.syms   |  2 ++
>  src/secret/secret_driver.c | 90 +++++++---------------------------------------
>  4 files changed, 87 insertions(+), 78 deletions(-)

ACK

Though there should probably be explicit virfile.c support for a generic
'rewrite file with this passed string', rather than requiring a callback.
src/network/leaseshelper.c already has something similar

- Cole




More information about the libvir-list mailing list