[libvirt] [PATCH 1/4] nss: Try harder to uninstall

John Ferlan jferlan at redhat.com
Tue Apr 19 14:10:33 UTC 2016



On 04/19/2016 09:50 AM, Michal Privoznik wrote:
> On BSD we are creating this symlink to libnss_libvirt.so called
> nss_libvirt.so. That's just the way it is on BSD. However, when
> uninstalling, we try to remove libnss_libvirt.so instead of the
> symlink. Moreover, if file we are trying to remove does not exist
> we error out instead of ignoring the error.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tools/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index 560a9a5..c474d75 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -427,7 +427,7 @@ install-exec-hook:
>  	  $(LN_S) libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER)
>  
>  uninstall-local:
> -	rm $(DESTDIR)$(libdir)/libnss_libvirt.so.$(NSS_SO_VER)
> +	-rm -f $(DESTDIR)$(libdir)/nss_libvirt.so.$(NSS_SO_VER)

        ^

Looks like a classic cut-n-paste error

ACK w/ the adjustment

John
>  else ! WITH_BSD_NSS
>  LIBVIRT_NSS_SYMBOL_FILE = \
>  	$(srcdir)/nss/libvirt_nss.syms
> 




More information about the libvir-list mailing list