[libvirt] [PATCH] network: Don't use ERR_NO_SUPPORT for invalid net-update requests
Jiri Denemark
jdenemar at redhat.com
Wed Apr 20 07:33:29 UTC 2016
On Tue, Apr 19, 2016 at 17:34:51 -0400, Cole Robinson wrote:
> VIR_ERR_NO_SUPPORT maps to the error string
>
> this function is not supported by the connection driver
>
> and is largely only used for when a driver doesn't have any
> implementation for a public API. So its usage with invalid
> net-update requests is a bit out of place. Instead use
> VIR_ERR_OPERATION_UNSUPPORTED which maps to:
>
> Operation not supported
>
> And is what qemu's hotplug routines use in similar scenarios
> ---
> src/conf/network_conf.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
ACK
Jirka
More information about the libvir-list
mailing list