[libvirt] [PATCH 00/14] conf: disk: Continue refactoring of virDomainDiskDefParseXML

Peter Krempa pkrempa at redhat.com
Wed Apr 20 15:58:10 UTC 2016


This is yet another dump of my quest to despaghettize virDomainDiskDefParseXML.

My eyes are starting to bleed a bit less, but there's still a lot of patches to
come.

Peter Krempa (14):
  conf: disk: Extract verification of disk config
  conf: disk: Split out parsing of disk <driver> element
  conf: disk: Avoid temporary variable when parsing driver name
  conf: disk: Sanitize parsing of disk format
  conf: disk: Mark VIR_DOMAIN_DISK_IO_DEFAULT as 0 and simplify parsing
  conf: disk: Remove custom single-use temporary variables
  conf: disk: Extract disk type and device right away
  conf: disk: Initialize closed device tray state to 0
  conf: disk: Don't bother setting removable state to 0 by default
  conf: disk: extract sgio/rawio validation
  conf: disk: Extract verification of disk tray
  conf: disk: Move validation of disk bus vs disk type
  conf: disk: Extract checking of removable status
  conf: disk: extract validation of startup policy

 src/conf/domain_conf.c | 452 ++++++++++++++++++++++++-------------------------
 src/conf/domain_conf.h |   4 +-
 2 files changed, 221 insertions(+), 235 deletions(-)

-- 
2.8.1




More information about the libvir-list mailing list