[libvirt] [PATCH] lxc: explicitly error on interface type=ethernet

[sonia verma]

Hi Team

Is there any breakthrough on this ?.


On Tue, Apr 19, 2016 at 9:15 PM, Daniel P. Berrange <berrange at redhat.com>
wrote:

> On Mon, Apr 11, 2016 at 10:56:57AM -0400, Cole Robinson wrote:
> > It isn't implemented and does not work:
> >
> > error: internal error: guest failed to start:
> /usr/lib/libvirt/libvirt_lxc: option '--veth' requires an argument
> > syntax: /usr/lib/libvirt/libvirt_lxc [OPTIONS] ...
> >
> > We previously threw an explicit error, but this changed in
> > 22cff52a2b8e06c913b1f97767e5d390fb17fc3b , which I suspect was
> > untested for LXC
> > ---
> >  src/lxc/lxc_process.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
> > index 5e0bbe2..0044ee5 100644
> > --- a/src/lxc/lxc_process.c
> > +++ b/src/lxc/lxc_process.c
> > @@ -559,8 +559,6 @@ static int
> virLXCProcessSetupInterfaces(virConnectPtr conn,
> >              break;
> >
> >          case VIR_DOMAIN_NET_TYPE_ETHERNET:
> > -            break;
> > -
> >          case VIR_DOMAIN_NET_TYPE_USER:
> >          case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
> >          case VIR_DOMAIN_NET_TYPE_SERVER:
>
> ACK
>
> Regards,
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/
> :|
> |: http://libvirt.org              -o-             http://virt-manager.org
> :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/
> :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc
> :|
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160421/9a58ba6e/attachment-0001.htm>