[libvirt] [PATCH 9/9] virStream{Recv, Send}All: Increase client buffer

Michal Privoznik mprivozn at redhat.com
Thu Apr 21 14:29:12 UTC 2016


On 20.04.2016 15:58, John Ferlan wrote:
> 
> 
> On 04/15/2016 09:51 AM, Michal Privoznik wrote:
>> These are wrappers over virStreamRecv and virStreamSend so that
>> users have to care about nothing but writing data into / reading
>> data from a sink (typically a file). Note, that these wrappers
>> are used exclusively on client side as the daemon has slightly
>> different approach. Anyway, the wrappers allocate this buffer and
>> use it for intermediate data storage until the data is passed to
>> stream to send, or to the client application. So far, we are
>> using 64KB buffer. This is enough, but suboptimal because server
>> can send messages up to VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX bytes
>> big (262120B, roughly 256KB). So if we make the buffer this big,
>> a single message containing the data is sent instead of for,
>                                                           ^^^
> I assume you mean, "s/for/four"

Er, yes. See? You understand this area of the code :)

Michal




More information about the libvir-list mailing list