[libvirt] [PATCH] conf: Drop restrictions on rng backend path

[Cole Robinson]

On 04/21/2016 04:06 AM, Peter Krempa wrote:
> On Wed, Apr 20, 2016 at 18:19:25 -0400, Cole Robinson wrote:
>> Currently we only allow /dev/random and /dev/hwrng as host input
>> for <rng><backend model='random'/> device. This was added after
>> various upstream discussions in commit 4932ef45
>>
>> However this restriction has generated quite a few complaints over
>> the years, so a new discussion was initiated:
>>
>> http://www.redhat.com/archives/libvir-list/2016-April/msg00987.html
>>
>> Several people suggested removing the restriction, and nobody really
>> spoke up to defend it. So this patch drops the path restriction
>> entirely
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1074464
>> ---
>>  docs/formatdomain.html.in                                     | 9 ++++-----
>>  docs/schemas/domaincommon.rng                                 | 3 +--
>>  src/conf/domain_conf.c                                        | 8 --------
>>  tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args    | 2 +-
>>  tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml     | 2 +-
>>  tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-rng-random.xml | 2 +-
>>  6 files changed, 8 insertions(+), 18 deletions(-)
>>
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index 895114b..132b261 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
> 
> ...
> 
>> @@ -6240,9 +6239,9 @@ qemu-kvm -net nic,model=? /dev/null
>>        <dd>
>>          <p>
>>            This backend type expects a non-blocking character device as input.
>> -          The only accepted paths are /dev/random and /dev/hwrng. The file
>> -          name is specified as contents of the <code>backend</code> element.
>> -          When no file name is specified the hypervisor default is used.
>> +          The file name is specified as contents of the
>> +          <code>backend</code> element. When no file name is specified the
>> +          this defaults to /dev/random.
> 
> I'd rather keep the "hypervisor default" wording. /dev/urandom is in no
> way platform or hypervisor agnostic. You may add though that for qemu
> driver the default indeed is /dev/random.
> 

Thanks, fixed locally. I'll wait till see if any other comments come in before
deciding whether to post a V2 or not

- Cole