[libvirt] [PATCH] qemu: Limit maximum block device I/O tune values

Martin Kletzander mkletzan at redhat.com
Fri Apr 22 06:33:49 UTC 2016


On Thu, Apr 21, 2016 at 10:42:43AM -0400, Cole Robinson wrote:
>On 04/21/2016 08:47 AM, Martin Kletzander wrote:
>> The values are currently limited to LLONG_MAX which causes some
>> problems.  QEMU conveniently changed their maximum to 1e15 (1 PB) which
>> is enough for some time and we need to adapt to that so that we don't
>> throw "Unknown error" messages.  Strictly limiting these values actually
>> fixes some corner case values (off-by-one checks in QEMU probably).
>>
>> Since values out of the new specified range do not overflow anything,
>> change the type of error as well.
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1317531
>>

I failed copy-pasting the bug number and only found out after pushing
this patch.  Sorry for that, the bug link should've been:

https://bugzilla.redhat.com/show_bug.cgi?id=1329041

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160422/ba1f1bd3/attachment-0001.sig>


More information about the libvir-list mailing list